Add full task and EBS volume context to EBS debug log messages #4276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singholt
previously approved these changes
Aug 9, 2024
danehlim
previously approved these changes
Aug 9, 2024
sparrc
force-pushed
the
cssparr-ebs-log-improvement
branch
2 times, most recently
from
2df9191
to
2a474d6
Compare
sparrc
force-pushed
the
cssparr-ebs-log-improvement
branch
from
2a474d6
to
529b9b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds task context to two EBS debug log messages. Without this context, the log messages are not very helpful since they just indicate that some task has EBS volumes. This change will allow us to narrow down the messages to particular tasks and EBS volume IDs.
Testing
New tests cover the changes: no
Description for the changelog
Enhancement: EBS volume logging improvement
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.