Adds branch ENI config to non-firecracker platforms #4436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor to allow branch ENIs to run on all platform types.
Implementation details
Previous version of the netlib had Branch-ENI configuration setup to work only on firecracker. Namely, in FC the task netns was connected to the vlan interface via a TAP connected to the microVM.
In non-FC instances, task ns need a way to communicate with TMDS. FC had MMDS binary running inside the microVM. In non-FC instances we create a bridge that routes packets to the primary netns where TMDS is running.
This PR has the review findings from this PR #4430
but I messed up the git commit history when I rebased to squash non-contiguous commits.
Testing
New tests cover the changes:
Yes
Description for the changelog
Enhancement: Refactors Branch ENI configuration to support all platform types.
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Does this PR include the addition of new environment variables in the README?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.