add ecr publish configuration #182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#141
Description of changes:
This makes modifications to support a publish workflow for this repo's docker image to public ECR and follows https://github.com/kubernetes-sigs/aws-ebs-csi-driver. This required modifying the Makefile to support multiarch building, the Dockerfile to support multiarch builds as well, and a provenance test script during the build process. These changes are then used in the new publish-ecr workflow copied from the aws-ebs-csi repo. The architectures supported are linux/arm64 and linux/amd64
make all-image-dockercreates the necessary images for local development, and make build was refactored to use the local systems ARCH be used in the build process. This will keep compatibility with the existing make steps.make all-pushis used in the new workflow to push to the appropriate registry the manifest and images built with buildxBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.