Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't push if there is no token or secret for dockerhub #199

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

nckturner
Copy link
Contributor

@nckturner nckturner commented Oct 26, 2023

Issue #, if available:

Description of changes:
Don't attempt to push to dockerhub if the token or secret variable isn't set.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@nckturner nckturner requested a review from a team as a code owner October 26, 2023 17:07
Copy link
Contributor

@josselin-c josselin-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • name: Build container and push to Dockerhub registry

This could be updated as well.

@nckturner nckturner merged commit b9e534a into aws:master Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants