Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s.io libraries to v0.29.1 to support sidecar containers #209

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

DanielCKennedy
Copy link
Contributor

@DanielCKennedy DanielCKennedy commented Jan 30, 2024

Issue #, if available:

#208

pod-identity-webhook is breaking sidecar due to the webhook not supporting Container.restartPolicy field

Description of changes:

  • Updates k8s.io libraries to v0.29.1

    • go get k8s.io/api ; go get k8s.io/client-go ; go mod tidy ; go mod vendor
  • Adds a unit test for sidecar containers

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@DanielCKennedy DanielCKennedy requested a review from a team as a code owner January 30, 2024 20:58
@DanielCKennedy DanielCKennedy changed the title Update k8s libraries to support sidecar containers Update k8s.io libraries to v0.29.1 to support sidecar containers Jan 30, 2024
Copy link
Contributor

@prateekgogia prateekgogia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants