Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a process hook for ensuring log groups exist #89

Open
rafidka opened this issue Jun 21, 2024 · 0 comments
Open

Create a process hook for ensuring log groups exist #89

rafidka opened this issue Jun 21, 2024 · 0 comments

Comments

@rafidka
Copy link
Contributor

rafidka commented Jun 21, 2024

Overview

Currently, we routinely ensure log groups exist in our log handler. We use a throttling mechanism to avoid excessively calling the CreateLogGroup API. This mechanism doesn't work well with task logs and DAG processing logs, the reason, I suspect, being that running tasks or processing DAGs involve the creation of a separate process, which breaks our throttling mechanism.

Additionally, the reliance on CreateLogGroup even if the log group exists results in a lot of false failures in the customer's CloudTrail event history.

To solve both these problems, I am proposing implementing the mechanism for ensuring log groups exist as a process hook (currently called process conditions, but planning to rename) and attaching it to the main processes of schedulers, workers, and web servers. This way we avoid the challenges that happen in multiprocessing.

Acceptance Criteria

  • Implement a process hook for ensuring the existence of log groups.
  • Use DescribeLogGroups API first to test whether the log group exists or not, instead of blindly calling CreateLogGroup.

Additional Info

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant