Disable log group creation in CloudWatch handlers #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log group creation via the `_ensure_log_group_exists()` is resulting in a spam of calls to CreateLogGroup API. We are temporarily disabling log group creation until we work on a better solution. More details on this can be found in #89.
|
This means if user deletes a log group the logging will not work properly? Can we call something like describe-log-groups API to confirm before we call create-log-group ? |
Yes, that's correct. If the user deletes the log groups, they will stop receiving logs, which is currently the case.
Yeah, this is the intention. See #89. |
Mercury2699
approved these changes
Jun 21, 2024
Kalhan22
approved these changes
Jun 21, 2024
|
@rafidka - while we work on a proper solution to address deletion of log group, can we at least have some error message in scheduler/worker logs that log group is missing? It would help customers troubleshoot faster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #89
Description of changes:
Log group creation via the
_ensure_log_group_exists()is resulting in a spam of calls to CreateLogGroup API. We are temporarily disabling log group creation until we work on a better solution. More details on this can be found in #89.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.