Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate, cache and pass valid fernet keys for local deployment (#196) #207

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

kashyapkannan
Copy link
Contributor

Issue #, if available: #196

Description of changes:

  • Modified run.sh to generate, cache and pass valid fernet key to the docker-compose file.
  • Added a script to be able to use pip install in run.sh to temporarily install dependencies needed before the bootstrap steps, like in this use-case.
  • Updated pip_install_check.py and run_all.py quality_check files' shebang for better portability.
  • Updated lint_bash check to exclude .venv's generated scripts.

Description of testing:

  • Built and ran image locally with the run.sh script.
  • Used log statements to verify the fernet key was valid and being passed correctly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

images/airflow/2.9.2/run.sh Show resolved Hide resolved
images/airflow/2.9.2/run.sh Outdated Show resolved Hide resolved
@vishalvijay18 vishalvijay18 merged commit 9963b55 into aws:main Jan 8, 2025
1 check passed
vishalvijay18 pushed a commit that referenced this pull request Jan 9, 2025
…#211)

*Issue #, if available:* #196

*Description of changes:*
- Adding the valid fernet key generation changes made in [this pull
request](#207) to
the 2.10.1 and 2.10.3 images as well.

Description of testing:

- Built and ran images locally with the run.sh script.
- Used log statements to verify the fernet key was valid and being
passed correctly.

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.

Co-authored-by: Kashyap Kannan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants