Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 50Mi memory requests for aws-node pod; update chart README #2760

Closed
wants to merge 2 commits into from

Conversation

jdn5126
Copy link
Contributor

@jdn5126 jdn5126 commented Jan 23, 2024

What type of PR is this?
enhancement

Which issue does this PR fix:
N/A

What does this PR do / Why do we need it:
This PR adds a 50Mi memory request field to the aws-node pod. Note that this request applies to the init container, main container, and network policy agent container by default.

This change is made for two reasons:

  1. It is good practice to specify CPU and memory requests
  2. This help node autoscalers like Karpenter avoid selecting instance sizes that are too small for pods to run on.

This PR also updates the README in the aws-vpc-cni helm chart to provide instructions on how to set the field manager to helm when installing the chart. Since Kubernetes recommends using server-side apply, the README uses it to apply the rendered helm chart.

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:

Testing done on this change:
Manually verified that the requests apply

Will this PR introduce any new dependencies?:
No

Will this break upgrades or downgrades? Has updating a running cluster been tested?:
No, Yes

Does this change require updates to the CNI daemonset config files to work?:
Yes

Does this PR introduce any user-facing change?:
Yes

Specify 50Mi memory request for containers in the aws-vpc-cni helm chart.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jdn5126 jdn5126 requested a review from a team as a code owner January 23, 2024 17:27
@jdn5126 jdn5126 changed the title Add 50Mi memory requests for aws-node pod Add 50Mi memory requests for aws-node pod; update chart README Jan 23, 2024
@jdn5126 jdn5126 force-pushed the chart_limits branch 2 times, most recently from 47748f8 to 1253018 Compare January 26, 2024 20:18
@jdn5126 jdn5126 closed this Feb 15, 2024
@jdn5126 jdn5126 deleted the chart_limits branch February 15, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant