Update AWS VPC CNI to SDK V2 Update - master branch #3070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orsenthil
force-pushed
the
sdk_v2_update
branch
3 times, most recently
from
3d25538 to
9af60b9
Compare
orsenthil
force-pushed
the
sdk_v2_update
branch
4 times, most recently
from
ef2146e to
4490661
Compare
orsenthil
force-pushed
the
sdk_v2_update
branch
from
8f59421 to
8b83393
Compare
orsenthil
force-pushed
the
sdk_v2_update
branch
from
0914a5d to
307a967
Compare
orsenthil
force-pushed
the
sdk_v2_update
branch
from
307a967 to
cd016a2
Compare
orsenthil
changed the title
orsenthil
changed the title
M00nF1sh
reviewed
Dec 4, 2024
| if errors.As(err, &awsErr) { | ||
| log.Debugf("Insufficient IP Addresses due to: %v\n", awsErr.Code()) | ||
| return awsErr.Code() == INSUFFICIENT_CIDR_BLOCKS || awsErr.Code() == INSUFFICIENT_FREE_IP_SUBNET | ||
| if errors.As(err, &apiErr) { |
There was a problem hiding this comment.
we should test whether those error check is still true with sdkv2.
There was a problem hiding this comment.
The Error messages themselves are service errors, those remain true. SDK exposes them via interface like ErrorCode() instead of Code(). I had verified with OperationsError. Relied in Integration tests for the others.
M00nF1sh
approved these changes
Dec 9, 2024
This was referenced Dec 9, 2024
orsenthil
commented
Feb 7, 2025
| HTTPClient: &http.Client{ | ||
| Timeout: getHTTPTimeout(), | ||
| }, | ||
| STSRegionalEndpoint: endpoints.RegionalSTSEndpoint, |
There was a problem hiding this comment.
How is the endpoints resolve option handled in the SDK v2:
STSRegionalEndpoint: endpoints.RegionalSTSEndpoint,
There was a problem hiding this comment.
^ In SDK v2, all sts interaction is regional only. It is transparently handled by SDK. This STSRegionalEndpoint: endpoints.RegionalSTSEndpoint, flag is not required andthe package endpoints is removed too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue - #3116
Ensure Integration Tests are successful before merge.
Integration Tests on IPV4
Integration Tests on IPv6
CNI Metrics Helper