Skip to content

Commit

Permalink
removed additional references to 'mesh'
Browse files Browse the repository at this point in the history
  • Loading branch information
erikfuller committed Oct 3, 2023
1 parent fa69a19 commit 7754bc6
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 16 deletions.
8 changes: 4 additions & 4 deletions pkg/deploy/lattice/service_network_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ type defaultServiceNetworkManager struct {
//
// return errors.New(LATTICE_RETRY) when:
//
// CreateServiceNetworkVpcAssociationInput returns ServiceNetworkVpcAssociationStatusFailed/ServiceNetworkVpcAssociationStatusCreateInProgress/MeshVpcAssociationStatusDeleteInProgress
// CreateServiceNetworkVpcAssociationInput returns ServiceNetworkVpcAssociationStatusFailed/ServiceNetworkVpcAssociationStatusCreateInProgress/ServiceNetworkVpcAssociationStatusDeleteInProgress

func (m *defaultServiceNetworkManager) CreateOrUpdate(ctx context.Context, serviceNetwork *model.ServiceNetwork) (model.ServiceNetworkStatus, error) {
// check if exists
Expand Down Expand Up @@ -266,13 +266,13 @@ func (m *defaultServiceNetworkManager) isServiceNetworkAlreadyAssociatedWithVPC(
if err == nil {
switch associationStatus {
case vpclattice.ServiceNetworkVpcAssociationStatusActive:
m.log.Debugf("Mesh and Vpc association is active.")
m.log.Debugf("ServiceNetwork and Vpc association is active.")
return true, r, resp, nil
case vpclattice.ServiceNetworkVpcAssociationStatusCreateFailed:
m.log.Debugf("Mesh and Vpc association does not exists, start creating service_network and vpc association")
m.log.Debugf("ServiceNetwork and Vpc association does not exists, start creating service_network and vpc association")
return false, r, resp, nil
case vpclattice.ServiceNetworkVpcAssociationStatusDeleteFailed:
m.log.Debugf("Mesh and Vpc association failed to delete")
m.log.Debugf("ServiceNetwork and Vpc association failed to delete")
return true, r, resp, nil
case vpclattice.ServiceNetworkVpcAssociationStatusDeleteInProgress:
m.log.Debugf("ServiceNetwork and Vpc association is being deleted, retry later")
Expand Down
11 changes: 6 additions & 5 deletions pkg/deploy/lattice/target_group_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,12 @@ func getLatticeTGName(targetGroup *model.TargetGroup) string {
//
// return errors.New(LATTICE_RETRY) when:
//
// CreateTargetGroupWithContext returns
// TG is TargetGroupStatusUpdateInProgress
// TG is MeshVpcAssociationStatusFailed
// TG is TargetGroupStatusCreateInProgress
// TG is TargetGroupStatusFailed
// CreateTargetGroupWithContext returns
// TG is TargetGroupStatusUpdateInProgress
// TG is TargetGroupStatusCreateFailed
// TG is TargetGroupStatusCreateInProgress
// TG is TargetGroupStatusDeleteFailed
// TG is TargetGroupStatusDeleteInProgress
//
// return nil when:
//
Expand Down
14 changes: 7 additions & 7 deletions pkg/gateway/model_build_listener_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ func Test_ListenerModelBuild(t *testing.T) {
CommonRouteSpec: gwv1beta1.CommonRouteSpec{
ParentRefs: []gwv1beta1.ParentReference{
{
Name: "mesh1",
Name: "gw1",
SectionName: &httpSectionName,
},
},
Expand Down Expand Up @@ -110,7 +110,7 @@ func Test_ListenerModelBuild(t *testing.T) {
CommonRouteSpec: gwv1beta1.CommonRouteSpec{
ParentRefs: []gwv1beta1.ParentReference{
{
Name: "mesh1",
Name: "gw1",
SectionName: &httpSectionName,
},
},
Expand Down Expand Up @@ -144,7 +144,7 @@ func Test_ListenerModelBuild(t *testing.T) {
CommonRouteSpec: gwv1beta1.CommonRouteSpec{
ParentRefs: []gwv1beta1.ParentReference{
{
Name: "mesh1",
Name: "gw1",
SectionName: &httpSectionName,
},
},
Expand Down Expand Up @@ -178,7 +178,7 @@ func Test_ListenerModelBuild(t *testing.T) {
CommonRouteSpec: gwv1beta1.CommonRouteSpec{
ParentRefs: []gwv1beta1.ParentReference{
{
Name: "mesh1",
Name: "gw1",
SectionName: &httpSectionName,
},
},
Expand Down Expand Up @@ -210,7 +210,7 @@ func Test_ListenerModelBuild(t *testing.T) {
CommonRouteSpec: gwv1beta1.CommonRouteSpec{
ParentRefs: []gwv1beta1.ParentReference{
{
Name: "mesh1",
Name: "gw1",
SectionName: &httpSectionName,
},
},
Expand Down Expand Up @@ -268,7 +268,7 @@ func Test_ListenerModelBuild(t *testing.T) {
CommonRouteSpec: gwv1beta1.CommonRouteSpec{
ParentRefs: []gwv1beta1.ParentReference{
{
Name: "mesh1",
Name: "gw1",
SectionName: &httpSectionName,
},
},
Expand Down Expand Up @@ -300,7 +300,7 @@ func Test_ListenerModelBuild(t *testing.T) {
CommonRouteSpec: gwv1beta1.CommonRouteSpec{
ParentRefs: []gwv1beta1.ParentReference{
{
Name: "mesh1",
Name: "gw1",
SectionName: &missingSectionName,
},
},
Expand Down

0 comments on commit 7754bc6

Please sign in to comment.