Add ability to pass CLUSTER_NAME env variable in helm chart (#436)

* Add ability to pass CLUSTER_NAME env variable for helm chart * address PR comments --------- Co-authored-by: Zijun Wang <[email protected]>
aws · Oct 16, 2023 · f68c970 · f68c970
1 parent c3d0ab9
commit f68c970
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 1 deletion.
diff --git a/docs/deploy.md b/docs/deploy.md
@@ -81,9 +81,10 @@ Run through them again for a second cluster to use with the extended example sho
       oci://public.ecr.aws/aws-application-networking-k8s/aws-gateway-controller-chart\
       --version=v0.0.17 \
       --set=serviceAccount.create=false --namespace aws-application-networking-system \
-      # Region, clusterVpcId, awsAccountId are required for case where IMDS is NOT AVAILABLE, e.g Fargate
+      # awsRegion, clusterVpcId, clusterName, awsAccountId are required for case where IMDS is NOT AVAILABLE, e.g Fargate, self-managed clusters with IMDS access blocked 
       --set=awsRegion= \
       --set=clusterVpcId= \
+      --set=clusterName= \
       --set=awsAccountId= \
 
    ```

diff --git a/helm/templates/configmap.yaml b/helm/templates/configmap.yaml
@@ -6,3 +6,5 @@ data:
     awsRegion: {{ .Values.awsRegion | quote }}
     awsAccountId: {{ .Values.awsAccountId | quote }}
     clusterVpcId: {{ .Values.clusterVpcId | quote }}
+    clusterName: {{ .Values.clusterName | quote }}
+
diff --git a/helm/templates/deployment.yaml b/helm/templates/deployment.yaml
@@ -82,6 +82,11 @@ spec:
               configMapKeyRef:
                 name: env-config
                 key: clusterVpcId
+          - name: CLUSTER_NAME
+            valueFrom:
+              configMapKeyRef:
+                name: env-config
+                key: clusterName
 
       terminationGracePeriodSeconds: 10
       nodeSelector: {{ toYaml .Values.deployment.nodeSelector | nindent 8 }}

diff --git a/helm/values.yaml b/helm/values.yaml
@@ -74,3 +74,4 @@ serviceAccount:
 awsRegion:
 awsAccountId:
 clusterVpcId:
+clusterName: