fix: reset to default settings if healthCheck is removed (#369) #405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
Which issue does this PR fix:
#369
What does this PR do / Why do we need it:
Fix bug #369 by resetting the health check configuration to default setting if
healthCheck
section is removedIf an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
Testing done on this change:
Manual testing, confirmed health check configuration is reset if removed. Also ran e2e tests
Automation added to e2e:
N/A
Will this PR introduce any new dependencies?: No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this PR introduce any user-facing change?: Yes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.