Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset to default settings if healthCheck is removed (#369) #405

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

scottlaiaws
Copy link
Contributor

What type of PR is this?
bug

Which issue does this PR fix:
#369

What does this PR do / Why do we need it:
Fix bug #369 by resetting the health check configuration to default setting if healthCheck section is removed

If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:

Testing done on this change:
Manual testing, confirmed health check configuration is reset if removed. Also ran e2e tests

Ran 31 of 31 Specs in 2030.679 seconds
SUCCESS! -- 31 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestIntegration (2031.56s)
PASS
ok      github.com/aws/aws-application-networking-k8s/test/suites/integration   2031.595s

Automation added to e2e:
N/A

Will this PR introduce any new dependencies?: No

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this PR introduce any user-facing change?: Yes

fix bug #369 

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@scottlaiaws
Copy link
Contributor Author

Previous PR: #400

@coveralls
Copy link

coveralls commented Sep 20, 2023

Pull Request Test Coverage Report for Build 6251576134

  • 71 of 71 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 39.06%

Totals Coverage Status
Change from base Build 6251256284: 0.4%
Covered Lines: 4031
Relevant Lines: 10320

💛 - Coveralls

Copy link
Contributor

@zijun726911 zijun726911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Seems previous PR accidentally closed

@scottlaiaws scottlaiaws merged commit 0999983 into aws:main Sep 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants