Logging Cleanup - Part 1 #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stener synthesizer. Added e2e-test and e2e-clean to make help output.
Pull Request Test Coverage Report for Build 6288346348
💛 - Coveralls |
mikhail-aws
approved these changes
Sep 25, 2023
| @@ -99,53 +109,46 @@ func (d *defaultListenerManager) Create(ctx context.Context, listener *latticemo | |||
| } | |||
|
|
|||
| resp, err := d.cloud.Lattice().CreateListener(&listenerInput) | |||
| if err != nil { | |||
| d.log.Errorf("Error during creation of Listener %s-%s", listenerSpec.Name, listenerSpec.Namespace) | |||
There was a problem hiding this comment.
I would return error here
There was a problem hiding this comment.
Would like to avoid behavioural changes in this PR, just improving logging/readability of code.
There was a problem hiding this comment.
in general for refactoring you are right, but in this particular example resp is used as non-nil value few lines below, it will panic on nil.
There was a problem hiding this comment.
Fair point, fixed next PR!
| } | ||
|
|
||
| return nil, errors.New("Listener does not exist") | ||
| return nil, errors.New("listener does not exist") |
There was a problem hiding this comment.
good to have listener details in error message, unless caller of this function wrap error with these details
| @@ -95,19 +102,18 @@ func (l *listenerSynthesizer) getSDKListeners(ctx context.Context) ([]*latticemo | |||
| var resService []*latticemodel.Service | |||
|
|
|||
| err := l.stack.ListResources(&resService) | |||
| glog.V(6).Infof("service: %v ignore err: %v \n", resService, err) | |||
| l.log.Debugf("Ignoring error when listing services %s", err) | |||
There was a problem hiding this comment.
Will do in part 2 PR, thanks for catching this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
cleanup
Which issue does this PR fix:
#126 partially
What does this PR do / Why do we need it:
e2e-testande2e-cleantomake helpoutput, which appear to have been inadvertently removed?If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
Testing done on this change:
Automation added to e2e:
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No
Does this PR introduce any user-facing change?:
No, only logging changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.