Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: scope down recommended inline policy (#48) #415

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

scottlaiaws
Copy link
Contributor

@scottlaiaws scottlaiaws commented Sep 28, 2023

What type of PR is this?

documentation

Which issue does this PR fix: #48

What does this PR do / Why do we need it: This PR scopes down the recommended inline policy according to the public documentation

If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:

Testing done on this change: N/A

Automation added to e2e: No

Will this PR introduce any new dependencies?: No

Will this break upgrades or downgrades. Has updating a running cluster been tested?: N/A

Does this PR introduce any user-facing change?: No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@coveralls
Copy link

coveralls commented Sep 28, 2023

Pull Request Test Coverage Report for Build 6342452656

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 46.204%

Totals Coverage Status
Change from base Build 6332043448: 0.0%
Covered Lines: 3931
Relevant Lines: 8508

💛 - Coveralls

Copy link
Contributor

@zijun726911 zijun726911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottlaiaws scottlaiaws merged commit 17825d0 into aws:main Sep 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants