Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to override LATTICE_ENDPOINT env variable with helm #446

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

xWink
Copy link
Member

@xWink xWink commented Oct 23, 2023

What type of PR is this?

feature

Which issue does this PR fix:
N/A

What does this PR do / Why do we need it:

  • Adds ability to override VPC Lattice endpoint when using helm

If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:

Testing done on this change:

N/A

Automation added to e2e:

N/A

Will this PR introduce any new dependencies?:

No

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No

Does this PR introduce any user-facing change?:

No


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@coveralls
Copy link

coveralls commented Oct 23, 2023

Pull Request Test Coverage Report for Build 6617925452

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 45.363%

Totals Coverage Status
Change from base Build 6569460474: 0.0%
Covered Lines: 4026
Relevant Lines: 8875

💛 - Coveralls

@xWink xWink merged commit 7120cce into aws:main Oct 23, 2023
5 checks passed
@xWink xWink deleted the lattice-endpoint-helm branch October 23, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants