Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local module support to the cloudformation package command #9124

Draft
wants to merge 54 commits into
base: develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
0438bdc
Initial commit with TODOs for implementing modules
ericzbeard Nov 22, 2024
84cb385
Unit test configured
ericzbeard Dec 4, 2024
9eac23a
Start resolving refs
ericzbeard Dec 4, 2024
0b79526
Resolve Refs
ericzbeard Dec 5, 2024
6f24f03
parse_sub
ericzbeard Dec 5, 2024
86a5d29
Sub strings
ericzbeard Dec 6, 2024
7b72e29
Basic tests pass
ericzbeard Dec 6, 2024
df507cd
Fixed pylint issues
ericzbeard Dec 6, 2024
7808f62
Fix path to unit tests
ericzbeard Dec 6, 2024
e2131d2
Add the ability to specify a module as a Resource
ericzbeard Dec 9, 2024
49fb392
Fix issues with nested Subs and lists
ericzbeard Dec 9, 2024
ec32ecf
Recursive modules
ericzbeard Dec 9, 2024
160be7c
Implement module outputs
ericzbeard Dec 13, 2024
e517720
Handle spaces in parse_sub
ericzbeard Dec 13, 2024
e8e6d96
Enum
ericzbeard Dec 13, 2024
5b0ee49
Code review fixes
ericzbeard Dec 13, 2024
4eef2c4
Code review fixes
ericzbeard Dec 13, 2024
72659f5
Fix merging lists
ericzbeard Dec 16, 2024
5cb126c
Vpc module example with a map
ericzbeard Dec 18, 2024
3ac0577
Use Map in the parent template
ericzbeard Dec 18, 2024
e0cfcfc
Moving docs to a readme
ericzbeard Dec 18, 2024
c6851c9
updating readme
ericzbeard Dec 18, 2024
dd16375
Handle extra dots in getatts
ericzbeard Dec 18, 2024
e119576
Fix manifest error
ericzbeard Dec 18, 2024
39ac9a7
Add basic conditional support
ericzbeard Dec 19, 2024
2f0143b
Added more complete unit test for conditionals
ericzbeard Dec 20, 2024
36305ec
Download modules from a URL
ericzbeard Jan 13, 2025
497fb3d
Removed the requirement for the s3-bucket parameter
ericzbeard Jan 13, 2025
6e36de0
Confirm GetAtt with double quotes works as expected
ericzbeard Jan 14, 2025
6212018
Fix unit test self.uploader
ericzbeard Jan 14, 2025
92ad3bd
Constants section
ericzbeard Jan 15, 2025
fa7c208
Constants example
ericzbeard Jan 16, 2025
30250b3
Minor tweaks to comments
ericzbeard Jan 16, 2025
32fa228
Constants
ericzbeard Jan 27, 2025
49615a8
Use a constant for module source url in test
ericzbeard Jan 30, 2025
ef49cbd
Merge remote-tracking branch 'upstream/develop' into cfn-modules
ericzbeard Feb 3, 2025
23442ce
Test sending arrays to props and fix output bug
ericzbeard Feb 4, 2025
73fd605
Fixing unit tests
ericzbeard Feb 5, 2025
b1c6a75
Fixed conditional test
ericzbeard Feb 5, 2025
6b36ca2
Implement conditionals within resources
ericzbeard Feb 5, 2025
2181e56
Fixed output getatt ref
ericzbeard Feb 5, 2025
db57872
Hide conditional modules
ericzbeard Feb 6, 2025
2a4b64a
Move export
ericzbeard Feb 7, 2025
5792b93
Merge remote-tracking branch 'upstream/develop' into cfn-modules
ericzbeard Feb 7, 2025
20ca09e
Move export metadata back
ericzbeard Feb 7, 2025
16fe030
Added Modules section to output processing
ericzbeard Feb 11, 2025
0713890
Removing Resource LocalModule imports
ericzbeard Feb 12, 2025
064fe42
Replace Parameters with Inputs and Outputs with References
ericzbeard Feb 12, 2025
e43c771
Parent can refer to module properties
ericzbeard Feb 13, 2025
9bf9ec8
Added AwsToolsMetrics
ericzbeard Feb 13, 2025
7795d1d
Add source map
ericzbeard Feb 13, 2025
1bbe6ea
Add line numbers to source map
ericzbeard Feb 13, 2025
f3b7dfe
Constant objects
ericzbeard Feb 14, 2025
85dee15
Replace Constants with Const
ericzbeard Feb 14, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Confirm GetAtt with double quotes works as expected
  • Loading branch information
ericzbeard committed Jan 14, 2025
commit 6e36de08ba13167ab8d3247efc414800d90798f7
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
Resources:
ContentBucket:
Type: AWS::S3::Bucket
Properties:
BucketName: foo
Outputs:
BucketName:
Value:
Fn::GetAtt:
- ContentBucket
- BucketName
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
Parameters:
Name:
Type: String
Resources:
Bucket:
Type: AWS::S3::Bucket
Properties:
BucketName: !Ref Name
Outputs:
BucketName: !GetAtt "Bucket.BucketName"
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
Resources:
Content:
Type: LocalModule
Source: ./getatt-module.yaml
Properties:
Name: foo
Outputs:
BucketName:
Value: !GetAtt Content.BucketName
1 change: 1 addition & 0 deletions tests/unit/customizations/cloudformation/test_modules.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ def test_main(self):
"conditional",
"cond-intrinsics",
"example",
"getatt",
]
for test in tests:
base = "unit/customizations/cloudformation/modules"
Expand Down
Loading