Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't enforce text format on uncaught exception warning message #182

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

dtorok
Copy link
Contributor

@dtorok dtorok commented Jan 23, 2025

Description of changes: Changing the warning message that's emitted when the user function raises an uncaught exception. This change addresses two problems with this warning:

  • in Telemetry API the warning message arrives unquoted, making the event JSON invalid
  • in CWL the warning message is always in text format, regardless of the log format configuration of the function

With this change

  • the TelemetryAPI event will be a valid json
  • the format of this warning message will match the format of any other logs the function produces

Target (OCI, Managed Runtime, both): both

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@briensea briensea self-assigned this Jan 23, 2025
@briensea briensea merged commit 4ccebc0 into aws:main Jan 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants