Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scaling] Removing usage of cfn-init for compute fleet #6655

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

himani2411
Copy link
Contributor

@himani2411 himani2411 commented Feb 10, 2025

Description of changes

  • Removing usage of cfn-init for compute fleet
  • Using write_files in user_data.sh of compute fleet

Dependent on cookbook PR aws/aws-parallelcluster-cookbook#2875

Tests

test-suites:
  update:
    test_update.py::test_dynamic_file_systems_update:
      dimensions:
        - regions: [ "us-east-2" ]
          instances: {{ common.INSTANCES_DEFAULT_X86 }}
          oss: [ "alinux2023" ]
          schedulers: [ "slurm" ]
    test_update.py::test_update_slurm:
      dimensions:
        - regions: ["eu-central-1"]
          instances: {{ common.INSTANCES_DEFAULT_X86 }}
          oss: ["rocky8"]
    test_update.py::test_update_compute_ami:
      dimensions:
        - regions: ["eu-west-1"]
          instances: {{ common.INSTANCES_DEFAULT_X86 }}
          oss: ["rocky9"]
    test_update.py::test_update_instance_list:
      dimensions:
        - regions: ["ap-south-1"]
          instances: {{ common.INSTANCES_DEFAULT_X86 }}
          oss: ["ubuntu2004"]
          schedulers: ["slurm"]
    test_update.py::test_queue_parameters_update:
      dimensions:
        - regions: [ "ap-south-1" ]
          instances: {{ common.INSTANCES_DEFAULT_X86 }}
          oss: ["alinux2"]
          schedulers: [ "slurm" ]
    test_update.py::test_dynamic_file_systems_update_rollback:
      dimensions:
        - regions: [ "us-east-2" ]
          instances: {{ common.INSTANCES_DEFAULT_X86 }}
          oss: [ "rhel8" ]
          schedulers: [ "slurm" ]

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Himani Anil Deshpande added 3 commits February 10, 2025 09:40
* Using cloud-init native approach for creating files
* Adding CFN LogicalId for Compute Launch Template
* Change dna.json and extra.json test for compute fleet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant