Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logic to handle number acceptors #5813

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add logic to handle number acceptors #5813

wants to merge 9 commits into from

Conversation

RanVaknin
Copy link

@RanVaknin RanVaknin commented Jan 21, 2025 •
edited
Loading

Motivation and Context

Currently the Java SDK waiter matcher acceptor only support Integers. According to the cross SDK spec waiter matcher acceptor must support all number types.

Modifications

  • Changed jmspathruntime numbers internally to use BigDecimal for all number types in order to support arbitrary precision.
  • Updated Jackson Jr version to 2.17.3 to support Big Decimal.

Testing

  • Added WaitersPathMatcherTest for numeric matchers
  • Added coverage to existing numeric handling tests

@RanVaknin RanVaknin changed the title add logic to handle number acceptors Add logic to handle number acceptors Jan 21, 2025
@RanVaknin RanVaknin force-pushed the rvaknin/number-support-for-waiters branch from 4fb548f to cd55716 Compare January 28, 2025 23:43
@RanVaknin RanVaknin marked this pull request as ready for review January 29, 2025 01:29
@RanVaknin RanVaknin requested a review from a team as a code owner January 29, 2025 01:29
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
50.4% Coverage on New Code (required ≥ 80%)
15.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RanVaknin