Update non-streaming error unmarshalling to use new mapping function #5991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes look good, but looks like existing Kinesis unit tests are failing, can we fix those? |
davidh44
reviewed
Apr 7, 2025
...ware/amazon/awssdk/codegen/poet/client/test-aws-query-compatible-json-sync-client-class.java
Outdated
Show resolved
Hide resolved
zoewangg
requested changes
Apr 7, 2025
|
|
||
| import static org.junit.Assert.assertEquals; | ||
|
|
||
| public class KinesisExceptionTest { |
There was a problem hiding this comment.
Can we use mock tests intead?
There was a problem hiding this comment.
Sure, updated the tests accordingly.
There was a problem hiding this comment.
Now that it's mock tests, can we move to test module instead of it?
There was a problem hiding this comment.
Done, moved it to the test module.
| @@ -202,4 +202,4 @@ public AwsQueryProtocolFactory build() { | |||
| return new AwsQueryProtocolFactory(this); | |||
| } | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
nit: can we avoid updating files that don't have meaningful change?
S-Saranya1
force-pushed
the
somepal/update-nonstreaming-error-unmarshaller
branch
from
1ba606b to
e687576
Compare
…ng integration test failures
…e new mapping function
S-Saranya1
force-pushed
the
somepal/update-nonstreaming-error-unmarshaller
branch
from
e687576 to
6079584
Compare
…TP connectors user-experience: 1) Customers can self-serve concurrent connections setting for their connectors, and 2) Customers can discover the public host key of remote servers using their SFTP connectors.
…puHours field in each TableOptimizerRun, providing clients visibility to the DPU-hours used for billing in managed Apache Iceberg table compaction optimization.
…'s Severity, CreateTime, and Identifier for a control's Implementation. The ListControls API now surfaces a control's Behavior, Severity, CreateTime, and Identifier for a control's Implementation.
davidh44
approved these changes
Apr 10, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update non-streaming error unmarshalling to use new mapping function.
Motivation and Context
This change updates the non-streaming error unmarshalling to use the same mapping function that was previously implemented for streaming operations. This change deprecates BaseAwsJsonProtocolFactory#createErrorResponseHandler(JsonOperationMetadata). We have switched all usages in generated code to the replacement, createErrorResponseHandler(JsonOperationMetadata,Function).
Modifications
registerModeledExceptioncalls frominitProtocolFactoryTesting
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License