URI cache for DynamoDB account id based endpoint #6087
+1,111
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' into feature/master/endpoint-id-cache
…' into feature/master/endpoint-id-cache
zoewangg
reviewed
May 6, 2025
utils/src/main/java/software/amazon/awssdk/utils/cache/lru/LruCache.java
Outdated
Show resolved
Hide resolved
utils/src/main/java/software/amazon/awssdk/utils/uri/SdkUri.java
Outdated
Show resolved
Hide resolved
utils/src/main/java/software/amazon/awssdk/utils/uri/SdkUri.java
Outdated
Show resolved
Hide resolved
utils/src/main/java/software/amazon/awssdk/utils/uri/SdkUri.java
Outdated
Show resolved
Hide resolved
codegen/src/main/java/software/amazon/awssdk/codegen/poet/rules2/CodeGeneratorVisitor.java
Show resolved
Hide resolved
zoewangg
requested changes
May 6, 2025
- added codegen tests - added equals & hash-code test for ConstructorArgs classes - fix cache size - SdkUri constructor - checkstyle complained about newURI -> renamed newUri
…' into feature/master/endpoint-id-cache
zoewangg
reviewed
May 7, 2025
| @@ -359,4 +359,8 @@ | |||
| <Class name="software.amazon.awssdk.v2migration.EnumCasingToV2$Visitor"/> | |||
| <Bug pattern="NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE"/> | |||
| </Match> | |||
| <Match> | |||
| <Class name="software.amazon.awssdk.utils.uri.SdkUri" /> | |||
| <Bug pattern="BC_UNCONFIRMED_CAST_OF_RETURN_VALUE" /> | |||
There was a problem hiding this comment.
Question: where do we cast?
There was a problem hiding this comment.
|
dagnir
requested changes
May 8, 2025
Comment on lines
+64
to
+65
| boolean containsK = cache.containsKey(key); | ||
| URI uri = cache.get(key); |
There was a problem hiding this comment.
This isn't 100% reliable since the key could have been inserted between 64 and 65. Do we actually need to log this? If we do, should it be done within LruCache instead?
| String authority, | ||
| String path, String query, String fragment) throws URISyntaxException { | ||
| if (!isAccountIdUri(authority)) { | ||
| log.trace(() -> "skipping cache for authority" + authority); |
| */ | ||
| private boolean isAccountIdUri(String s) { | ||
| int firstCharAfterScheme = 0; | ||
| int maxIntSizeBase10 = 10; |
There was a problem hiding this comment.
Make static constant. Also maybe maxIntDigitsBase10
| String userInfo, String host, int port, | ||
| String path, String query, String fragment) throws URISyntaxException { | ||
| if (!isAccountIdUri(host)) { | ||
| log.trace(() -> "skipping cache for host" + host); |
zoewangg
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Add caching for account id based endpoint in front of the URI constructors
Modifications
SdkURIclass which caches calls to the various URI constructors methods.SdkURIclass in generated endpoint resolution code. Enabled this config only for DynamoDB.Testing
Types of changes