-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Symfony 6 compability #88
Comments
Same here. In every request in my project, in the debug toolbar i see this deprecation: |
Related: app.WARNING: Failed to generate ConfigBuilder for extension Aws\Symfony\DependencyInjection\AwsExtension. {"exception":"[object] (LogicException(code: 0): The node was expected to be an ArrayNode. This Configuration includes an edge case not supported yet. at /home/tac/ca/ac/vendor/symfony/config/Builder/ConfigBuilderGenerator.php:108)","extensionClass":"Aws\Symfony\DependencyInjection\AwsExtension"} [] |
Hi @evzzz, thanks for reporting this. I have added a needs-review label so we can investigate this further. Thanks! |
I see this library has a large range of which version of Symfony it supports, even though most of them are unsupported by Symfony. I wonder if that's why this issue is present? It's also kinda silly to support PHP 5.5 since PHP 8 is the lowest version supported by PHP, everything older than that is end of life. It kinda makes me nervous to use this library. |
Symfony 7 will be released in November, at which point these deprecations will become errors. |
To chip in with deprecations
@SamRemis what are the plans for pushing these fixes forward and deprecating old versions of php & symfony as discussed in #81 ? |
Should the title be updated to Symfony 7 compatibility? |
Hey @yenfryherrerafeliz, OK, thanks. For the record, that PR was opened a few days after I asked the question. |
|
Describe the bug
Method "Symfony\Component\Config\Definition\ConfigurationInterface::getConfigTreeBuilder()" might add "TreeBuilder" as a native return type declaration in the future. Do the same in implementation "Limenius\ReactBundle\DependencyInjection\Configuration" now to avoid errors or add an explicit @return annotation to suppress this message.
Expected Behavior
Always time
Current Behavior
show deprecation message
Reproduction Steps
upgrade you project for Symfony 5.4 / 6.0
Possible Solution
No response
Additional Information/Context
No response
SDK version used
2.5.0
Environment details (OS name and version, etc.)
MacOS
The text was updated successfully, but these errors were encountered: