Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Symfony 6 compability #88

Closed
evzzz opened this issue Jun 19, 2022 · 11 comments
Closed

Add Symfony 6 compability #88

evzzz opened this issue Jun 19, 2022 · 11 comments
Assignees
Labels
bug This issue is a bug. needs-review p2 This is a standard priority issue

Comments

@evzzz
Copy link

evzzz commented Jun 19, 2022

Describe the bug

Method "Symfony\Component\Config\Definition\ConfigurationInterface::getConfigTreeBuilder()" might add "TreeBuilder" as a native return type declaration in the future. Do the same in implementation "Limenius\ReactBundle\DependencyInjection\Configuration" now to avoid errors or add an explicit @return annotation to suppress this message.

Expected Behavior

Always time

Current Behavior

show deprecation message

Reproduction Steps

upgrade you project for Symfony 5.4 / 6.0

Possible Solution

No response

Additional Information/Context

No response

SDK version used

2.5.0

Environment details (OS name and version, etc.)

MacOS

@evzzz evzzz added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jun 19, 2022
@diegosch21
Copy link

diegosch21 commented Jul 4, 2022

Same here. In every request in my project, in the debug toolbar i see this deprecation:
Method "Symfony\Component\Config\Definition\ConfigurationInterface::getConfigTreeBuilder()" might add "TreeBuilder" as a native return type declaration in the future. Do the same in implementation "Aws\Symfony\DependencyInjection\Configuration" now to avoid errors or add an explicit @return annotation to suppress this message.

@tacman
Copy link

tacman commented Aug 5, 2022

Related: app.WARNING: Failed to generate ConfigBuilder for extension Aws\Symfony\DependencyInjection\AwsExtension. {"exception":"[object] (LogicException(code: 0): The node was expected to be an ArrayNode. This Configuration includes an edge case not supported yet. at /home/tac/ca/ac/vendor/symfony/config/Builder/ConfigBuilderGenerator.php:108)","extensionClass":"Aws\Symfony\DependencyInjection\AwsExtension"} []

@yenfryherrerafeliz yenfryherrerafeliz added the p2 This is a standard priority issue label Apr 7, 2023
@yenfryherrerafeliz yenfryherrerafeliz removed the needs-triage This issue or PR still needs to be triaged. label May 15, 2023
@yenfryherrerafeliz yenfryherrerafeliz self-assigned this May 15, 2023
@yenfryherrerafeliz
Copy link
Contributor

Hi @evzzz, thanks for reporting this. I have added a needs-review label so we can investigate this further.

Thanks!

@eman1986
Copy link

I see this library has a large range of which version of Symfony it supports, even though most of them are unsupported by Symfony. I wonder if that's why this issue is present? It's also kinda silly to support PHP 5.5 since PHP 8 is the lowest version supported by PHP, everything older than that is end of life. It kinda makes me nervous to use this library.

@rhyd42
Copy link

rhyd42 commented Sep 4, 2023

Symfony 7 will be released in November, at which point these deprecations will become errors.

@boskos-q
Copy link

To chip in with deprecations

Method "Symfony\Component\DependencyInjection\Extension\ExtensionInterface::load()" might add "void" as a native return type declaration in the future. Do the same in implementation "Aws\Symfony\DependencyInjection\AwsExtension" now to avoid errors or add an explicit @return annotation to suppress this message.

@SamRemis what are the plans for pushing these fixes forward and deprecating old versions of php & symfony as discussed in #81 ?
Thanks

@janklan
Copy link

janklan commented Dec 7, 2023

Should the title be updated to Symfony 7 compatibility?

@yenfryherrerafeliz
Copy link
Contributor

Hi @janklan, there is a feature request for Symfony 7 support already here. We will look at it soon. Please refer to that feature request for more updates.

Thanks!

@janklan
Copy link

janklan commented Jan 8, 2024

Hey @yenfryherrerafeliz,

OK, thanks.

For the record, that PR was opened a few days after I asked the question.

@yenfryherrerafeliz
Copy link
Contributor

Hi @diegosch21, @tacman, @eman1986, @rhyd42, @boskos-q, and @janklan, we have introduced support for Symfony 7 in the following release.

Please reach out if is there anything else we can help with.

Thanks!

Copy link

github-actions bot commented Feb 5, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. needs-review p2 This is a standard priority issue
Projects
None yet
8 participants