Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify in PHPDoc the return type of Configuration::getConfigTreeBuilder #95

Closed
wants to merge 1 commit into from

Conversation

kaznovac
Copy link

@kaznovac kaznovac commented Apr 22, 2023

Issue #, if available:
Resolves #88

Description of changes:
Added the return type of TreeBuilder to the Configuration::getConfigTreeBuilder to avoid the following Deprecation notice:

Method "Symfony\Component\Config\Definition\ConfigurationInterface::getConfigTreeBuilder()" might add "TreeBuilder" as a native return type declaration in the future. Do the same in implementation "Aws\Symfony\DependencyInjection\Configuration" now to avoid errors or add an explicit @return annotation to suppress this message.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@RanVaknin
Copy link

Hi there,

It seems like this was already taken care of previously

public function getConfigTreeBuilder(): TreeBuilder

now getConfigTreeBuilder explicitly returns TreeBuilder

Thanks,
Ran~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Symfony 6 compability
3 participants