-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Symfony 7 #103
Support Symfony 7 #103
Conversation
This would be amazing 🙏 , it's the last blocker for Symfony 7 upgrade |
I am working on getting the tests to succeed since just the Composer changes won't cut it 😢. |
I also noticed #81 where the modernisation of the tool is mentioned for PHP 8 support, I wonder if the same will happen here (I imagine so). |
@ttomdewit Wow, 2 years old PR. Seems like this package is abandoned for good. |
Seems one of these last week active forks could be a good candidate: |
Fork/work in progress: TomasVotruba/aws-sdk-php-symfony#1 |
@TomasVotruba you work fast 😛 |
Yeah sadly, I am already considering alternatives (just use the PHP SDK without the Symfony bundle stuff or alternatively I've been told about https://async-aws.com/) |
I have to be fast, so it's working today :) Here is tagged package to try out Feedback is appreciated 👍 |
Let me give it a try tomorrow. Will report back. |
Nice one @TomasVotruba ! Any chance you're able to submit a PR so your changes can be part of the official repo? .. that way everyone can stay updated as other changes are contributed. Thank you for all your work & happy new year! |
@victormacko Thanks, once this PR and the PHP 8.0 gets merged, I'd be happy to send PR. |
Looking good! There is a release happening soon at |
Man we need this terribly, thanks in advance |
@mehmetsen80 Awesome! It's up and running past 3 weeks 👍 |
@TomasVotruba Unfortunately, the composer require aws/aws-sdk-php-symfony has still conflicts for Symfony 7 aws/aws-sdk-php-symfony[2.1.0, ..., 2.2.2] require symfony/config ~2.3|~3.0|~4.0|~5.0 -> found symfony/config[v2.3.0, ..., v2.8.52, v3.0.0, ..., v3.4.47, v4.0.0, ..., v4.4.44, v5.0.0, ..., v5.4.31] but these were not loaded, likely because it conflicts with another require. UPDATE: I see that it's on your packagist, hopefully it will be official soon! |
Hi @ttomdewit, thanks for your contribution. We did create a new PR, based on this one, for addressing this and we also introduced other changes such as deprecating PHP versions below 7.2.5 and adding support for PHP 8 and up. Those new changes are now available in the following release. So please folks reach out if you need anything else that we can help with. Thanks! |
Issue #, if available:
Solves #102
Description of changes:
Add 7 range to Composer file for Symfony related packages.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.