Update ext.requests to patch send instead of request
#456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patching the `send` function instead of `request` (this achieves the same affect)
Minitour
changed the title
send instead of request
Fixed requests patch issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patching the
sendfunction instead ofrequest(this achieves the same affect)Description of changes:
The requests library uses the
sendfunction to perform the HTTP call.The call stack is as follows:
request->sendIn other words, the
requestfunction calls thesendfunction.Some third party libraries use the
sendfunction directly, where they prepare the request (using some request builder function) and then send it withsend.A notable example of this is OpenSearch python client
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.