feat: added support for raw stats from RTCPeerConnection #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pallab-gain
reviewed
Jan 10, 2019
There was a problem hiding this comment.
This is going to be a very useful feature for users who want to build their own quality control implementation and algorithm based on the RTC stats. Thanks for exposing this.
I was wondering whether we can check iceConnectionState for 'connected' or 'completed' instead of signalingState to be 'stable' ? Because, signalingState can also be 'stable' when there is no active connection, for example in the initial state( https://www.w3.org/TR/webrtc/#rtcsignalingstate-enum ) before SDP generate, and negotiation, and in this state RTCStats doesn't provide useful stats.
RTCStats in different ice, and signaling state :
https://jsfiddle.net/pallab8077/skuomjpa/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Currently the
getStats()returns data that is translated and highly structured. This does not give client's much flexibility when compiling stats from the call.Description of changes:
Added
getStatsRaw()to enable clients to digest the raw stats from RTCPeerConnection object rather than the media tracks themselves.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.