Refresh stale peer conection based on ICE connection state #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjpat
approved these changes
Feb 18, 2022
Vignendra
reviewed
Feb 19, 2022
| @@ -871,7 +871,7 @@ export default class RtcSession { | |||
| var now = new Date(); | |||
| self._sessionReport.sessionStartTime = now; | |||
| self._connectTimeStamp = now.getTime(); | |||
| if (pc && pc.signalingState != 'closed') { | |||
| if (pc && pc.iceConnectionState != 'closed' && pc.iceConnectionState != 'failed' && pc.iceConnectionState != 'disconnected') { | |||
There was a problem hiding this comment.
We decided that we will be adding unit tests for any changes going forward. So please make sure this change is unit tested.
Vignendra
requested changes
Feb 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
With persistent connection feature, RTC sessions can become stale if the CCP enters sleep/hibernate mode. This change will check the health of the ICE connection before connecting and recreate the peer connection if the ICE connection is not in a healthy state. If the ICE connection state is closed, failed, or disconnected then the peer connection may be stale or unusable and should be recreated. See https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/iceConnectionState for documentation on ice connection state
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.