GitHub actions - Build Release Binaries #46
Conversation
Added on release branches restriction
GitHub actions - Build Release Binaries
Added write permissions
Update build_release_binaries.yml
|
Thank you for your contribution @elvzan. Our team will take a look at this and get back to you with any comments. |
|
@jamolina Let me know if you have any questions |
|
@elvzan thank you! Sorry for the delay. We will get back to you soon |
|
@jamolina No worries. Any eta on approving the pull request? |
|
Hey @elvzan, thank you again for your contribution, and apologies for the delay. Your code looks great and covers all 3 supported platforms (Linux, MacOs, and Windows). At AWS we are constantly raising the bar on security. As part of this commitment, we are required to sign our binaries so our customers are sure when a tool is coming from AWS. Unfortunately, because of this, we cannot accept your contribution at this time. We hope this does not discourages you from any future contributions on this or other projects. If you’re interested in contributing in another feature of the tool, feel free to create an issue or comment on an existing one about your plans so we can discuss it further. |
|
@jamolina thanks for getting back on this. Will you aws be looking to extend the pull request to sign the binaries? |
|
@elvzan unfortunately, our signing process is a little different, so we won't be able to re-use this PR |
Description of change
Created a git hub action event based on 'release' to build binaries and upload it to the Release Artifacts
Notes
Upon creation/publication of a Release, the build release binary will create and upload a Windows, Mac, and Ubuntu binary.
Issue
Resolves #40