fix(s2n-quic-dc): make TCP shutdown a no-op

aws · Dec 4, 2024 · a541b76 · a541b76
1 parent 4e85ccb
commit a541b76
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/dc/s2n-quic-dc/src/stream/socket/fd/tcp.rs b/dc/s2n-quic-dc/src/stream/socket/fd/tcp.rs
@@ -60,12 +60,3 @@ where
         unsafe { libc::sendmsg(fd, &msg, flags) }
     } as _)
 }
-
-#[inline]
-pub fn shutdown<T>(fd: &T) -> io::Result<()>
-where
-    T: AsRawFd,
-{
-    libc_call(|| unsafe { libc::shutdown(fd.as_raw_fd(), libc::SHUT_WR) as _ })?;
-    Ok(())
-}
diff --git a/dc/s2n-quic-dc/src/stream/socket/tokio/tcp.rs b/dc/s2n-quic-dc/src/stream/socket/tokio/tcp.rs
@@ -138,7 +138,7 @@ impl Socket for TcpStream {
 
     #[inline]
     fn send_finish(&self) -> io::Result<()> {
-        // AsyncWrite::poll_shutdown requires a `&mut self` so we just use libc directly
-        tcp::shutdown(self)
+        // Since we authenticate socket closures, no need to also shutdown the TCP layer
+        Ok(())
     }
 }