-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1084: decode body if base64 is enable #1085
#1084: decode body if base64 is enable #1085
Conversation
by default the content-type must be application/json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your contribution. Agree that this needs to be fixed. Could you reduce the duplicated code?
We plan to have a release early next week and it would be great to include it.
...gboot3/src/main/java/com/amazonaws/serverless/proxy/spring/AwsSpringHttpProcessingUtils.java
Outdated
Show resolved
Hide resolved
...gboot3/src/main/java/com/amazonaws/serverless/proxy/spring/AwsSpringHttpProcessingUtils.java
Outdated
Show resolved
Hide resolved
...gboot3/src/main/java/com/amazonaws/serverless/proxy/spring/AwsSpringHttpProcessingUtils.java
Outdated
Show resolved
Hide resolved
...gboot3/src/main/java/com/amazonaws/serverless/proxy/spring/AwsSpringHttpProcessingUtils.java
Outdated
Show resolved
Hide resolved
8e79023
to
56be654
Compare
Thank you very much for your contribution, @npeters! The changes have been merged and will be part of the next release. |
Issue #1084:
Description of changes:
if isBase64Encoded == true then AwsStringHttpProcessingUtils must decode the body
By submitting this pull request