Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1084: decode body if base64 is enable #1085

Conversation

npeters
Copy link
Contributor

@npeters npeters commented Oct 19, 2024

Issue #1084:

Description of changes:
if isBase64Encoded == true then AwsStringHttpProcessingUtils must decode the body

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@npeters
Copy link
Contributor Author

npeters commented Oct 21, 2024

by default the content-type must be application/json

@deki deki requested a review from olegz October 22, 2024 07:22
Copy link
Collaborator

@deki deki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution. Agree that this needs to be fixed. Could you reduce the duplicated code?
We plan to have a release early next week and it would be great to include it.

@npeters npeters force-pushed the fix/#1084-ServerlessHttpServletRequest.content-decode-base64 branch from 8e79023 to 56be654 Compare November 24, 2024 13:54
@deki deki merged commit 506dbb1 into aws:main Nov 25, 2024
4 checks passed
@deki
Copy link
Collaborator

deki commented Nov 25, 2024

Thank you very much for your contribution, @npeters! The changes have been merged and will be part of the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants