Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renesas_example: add example building the an image for renesas #24

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

thomas-roos
Copy link
Contributor

No description provided.

nateglims
nateglims previously approved these changes Oct 10, 2023
@@ -13,7 +13,7 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
# Install packages used elsewhere in the build
RUN apt-get install -y --no-install-recommends \
uuid-runtime sysstat iproute2 openssh-client curl python-is-python3 \
parted mtools dosfstools jq gpg gpg-agent qemu-utils
parted mtools dosfstools jq gpg gpg-agent qemu-utils rsync
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is rsync for here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary for renesas yocto build. Does require this as a native tool


POKY_COMMIT=74b22db6879b388d700f61e08cb3f239cf940d18
META_OE_COMMIT=814eec96c2a29172da57a425a3609f8b6fcc6afe
META_RENESAS_COMMIT=c5b39adbabdb8fd51517cf37190552b8fb57d062
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider going this route (extracting the logic into a Bash script and calling it in the build spec) for all our images 'types', for consistency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can discuss this. It was done that way because they provided that script.

alinadima
alinadima previously approved these changes Oct 11, 2023
# Clone basic Yocto layers in parallel
# git clone git://git.yoctoproject.org/poky -b kirkstone &
# git clone git://git.openembedded.org/meta-openembedded -b kirkstone &
# git clone https://github.com/renesas-rcar/meta-renesas -b kirkstone-dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we not using the repo tool/manifest file pattern here? Where are the layers added to the conf?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does copy the bblayers conf of that sample
cp ${WORK}/meta-renesas/meta-rcar-gen3/docs/sample/conf/${TARGET_BOARD}/poky-gcc/mmp/*.conf ./conf

@thomas-roos thomas-roos dismissed stale reviews from alinadima and nateglims via 57b5452 October 11, 2023 13:17
@thomas-roos thomas-roos force-pushed the renesas_example branch 2 times, most recently from 57b5452 to 8eabee0 Compare October 11, 2023 13:21
@thomas-roos thomas-roos merged commit c30a2e8 into main Oct 11, 2023
10 checks passed
@thomas-roos thomas-roos deleted the renesas_example branch October 11, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants