Fix: Lock can be acquired after lease duration if the current owner has been terminated unexpectedly when using skipBlockingWait=true #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-ryan-square
changed the title
somaniamit
approved these changes
Aug 4, 2022
…the time values could be in different jvms - nonoTime will no longer work
|
I could be wrong, but the addition of the LOOKUP_TIME attribute means that this would be a great solution for: I wonder if it would be even better to store an 'expiration time' instead, as that could be functionally the same but also allow for easy integration with the TTL feature: https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/TTL.html |
shetsa-amzn
previously approved these changes
May 22, 2023
shetsa-amzn
dismissed
their stale review
This change has been pushed to branch v1.3.x, will be merged to master using this PR: #91
|
I agree that we should abandon this proposed change for #88 after it is revised. |
|
No longer required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: 44
Description of changes:
This solves the problem with the issue raised, allowing skipBlockingWait flag to be used safely. It tracks the "lookupTime" for the lock to handle if another client that has the lock has been terminated unexpectedly - and therefore can't update the lock itself.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.