Skip to content

Commit

Permalink
Fixed fragmentation bugs for secure channel, alpn no longer fails the… (
Browse files Browse the repository at this point in the history
#111)

* Fixed fragmentaiton bugs for secure channel, alpn no longer fails the negotiation if one of the endpoints didn't negotiate.

* Fixed bug in iocp socket callback, logging stuff it shouldn't and more fragmentation fixes for securechannel.

* Addressed PR feedback.

* Fixed warning on windows about append_failed
  • Loading branch information
JonathanHenson authored and justinboswell committed Mar 16, 2019
1 parent c109ffe commit 1a8c19e
Show file tree
Hide file tree
Showing 2 changed files with 129 additions and 116 deletions.
6 changes: 3 additions & 3 deletions source/windows/iocp/socket.c
Original file line number Diff line number Diff line change
Expand Up @@ -835,8 +835,8 @@ void s_socket_connection_completion(
AWS_LOGF_ERROR(
AWS_LS_IO_SOCKET,
"id=%p handle=%p: connect completion triggered with error %d",
(void *)socket_args->socket,
(void *)socket_args->socket->io_handle.data.handle,
(void *)socket,
(void *)socket->io_handle.data.handle,
status_code);
int error = s_determine_socket_error(status_code);
socket_impl->vtable->connection_error(socket, error);
Expand Down Expand Up @@ -958,7 +958,7 @@ static inline int s_tcp_connect(
}

AWS_LOGF_TRACE(
AWS_LS_IO_TLS,
AWS_LS_IO_SOCKET,
"id=%p handle=%p: connection pending, scheduling timeout task",
(void *)socket,
(void *)socket->io_handle.data.handle);
Expand Down
Loading

0 comments on commit 1a8c19e

Please sign in to comment.