Apply suggestions from code review

Co-authored-by: Michael Graeb <[email protected]>
awslabs · Dec 21, 2023 · 5c01f7e · 5c01f7e
1 parent fea7cdc
commit 5c01f7e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/source/s3_meta_request.c b/source/s3_meta_request.c
@@ -1940,7 +1940,8 @@ void aws_s3_meta_request_finish_default(struct aws_s3_meta_request *meta_request
         struct aws_linked_list_node *request_node = aws_linked_list_pop_front(&release_request_list);
         struct aws_s3_request *release_request = AWS_CONTAINER_OF(request_node, struct aws_s3_request, node);
         AWS_FATAL_ASSERT(release_request != NULL);
-        /* The pending body streaming requests cleaned up here. Finish the metrics for those requests. */
+        /* This pending-body-streaming request was never moved to the event-delivery queue,
+         * so its metrics were never finished. Finish them now. */
         s_s3_request_finish_up_metrics(release_request, meta_request);
         aws_s3_request_release(release_request);
     }

diff --git a/tests/s3_cancel_tests.c b/tests/s3_cancel_tests.c
@@ -305,6 +305,8 @@ static int s3_cancel_test_helper_ex(
             .validate_type = AWS_S3_TESTER_VALIDATE_TYPE_EXPECT_FAILURE,
             .get_options =
                 {
+                    /* Note 1: 10MB object with 16KB parts, so that tests have many requests in-flight.
+                     * We want to try and stress stuff like parts arriving out of order. */
                     .object_path = g_pre_existing_object_10MB,
                 },
         };