Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the binding to use features from aws-c-s3 #509

Merged
merged 6 commits into from
Oct 12, 2023
Merged

Update the binding to use features from aws-c-s3 #509

merged 6 commits into from
Oct 12, 2023

Conversation

TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Oct 9, 2023 •
edited
Loading

  • Remove the hack we did in the bindings for progress callback and filepath
  • We still haven't support recv_filepath from aws-c-s3 yet, so keep that
  • Refactor the tests to be a bit nicer, as it was really confusing (sorry I wrote the old code, and I don't like it anymore. And it may still be confusing, I only updated the code around put object.)
  • add tests fro unknown content length

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

graebm
graebm reviewed Oct 10, 2023
View reviewed changes
source/s3_meta_request.c Show resolved Hide resolved
source/s3_meta_request.c Show resolved Hide resolved
source/s3_meta_request.c Show resolved Hide resolved
@TingDaoK TingDaoK requested a review from graebm October 10, 2023 23:27
@TingDaoK TingDaoK merged commit 67a6eaf into main Oct 12, 2023
63 checks passed
@TingDaoK TingDaoK deleted the use-filepath-in-c branch October 12, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graebm graebm graebm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TingDaoK @graebm