Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go mod update #180

Merged
merged 2 commits into from
Sep 15, 2023
Merged

go mod update #180

merged 2 commits into from
Sep 15, 2023

Conversation

tharun-d
Copy link
Contributor

we are using this package in production which has security vulnerabilities

Description of changes:
updating go mod packages and also go version

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

go.mod Outdated
@@ -1,37 +1,92 @@
module github.com/awslabs/aws-lambda-go-api-proxy

go 1.14
go 1.18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tharun-d How about upgrading to 1.20 or 1.19?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @drakejin updated to 1.20

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! It's better!

@drakejin
Copy link
Contributor

I think we should upgrade Golang version to avoid security issues.

Also, You should check below PR. @sapessi Same context.

#177

@tharun-d
Copy link
Contributor Author

tharun-d commented Jun 1, 2023

Hi @drakejin @sapessi can we get this merged ASAP, we have serious security issues in GIN package which will get resolved by this merge

@tharun-d
Copy link
Contributor Author

Hi @drakejin @sapessi can we get some eyes on this

@drakejin
Copy link
Contributor

I have no right to merge. cc @sapessi ..

@tharun-d
Copy link
Contributor Author

@sapessi can we merge this

@nicholas-keers
Copy link

Hello, I would love if you could merge this please @sapessi, the dependencies are starting to get some issues and the library has been left stale for a quite a few months now

@dza89 dza89 mentioned this pull request Sep 9, 2023
@sapessi sapessi merged commit 581201a into awslabs:master Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants