Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix upgrade echo to v4 as per upstream instructions #50

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wolfeidau
Copy link

https://github.com/labstack/echo#supported-go-versions

Issue #, if available:

Description of changes:

Upgrade echo to v4 as per upstream instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sapessi
Copy link
Collaborator

sapessi commented Feb 5, 2020

Were there any breaking changes between v4 and v3? Today we support v3 and I'm concerned that just changing to v4 may cause issues for existing users.

@wolfeidau
Copy link
Author

@sapessi you make a very good point, with libraries like this it may require a new package or function to indicate different major versions.

My experience due to the namespace changes you need to be explicit about echo vs v4.

Did you want me to refactor this PR to be echov4 in a separate file / package?

@sapessi
Copy link
Collaborator

sapessi commented Feb 5, 2020

I would probably create it as a separate echov4 folder. However, we'd have to include both echo v3 and v4 as dependencies - it's all one module at the moment - that is going to be a bit of a hellish experience. Do you have alternatives?

@sapessi sapessi mentioned this pull request Feb 6, 2020
@wolfeidau
Copy link
Author

I think this repo is a good case for moving to a multi module project. This would look as follows:

  1. create a new echov4 folder in this repo and add my code.
  2. mod init in that folder for github.com/awslabs/aws-lambda-go-api-proxy/echov4
  3. mod init in echo folder for github.com/awslabs/aws-lambda-go-api-proxy/echo
  4. mod tidy in the root folder which will remove the deps of these sub modules
  5. Push a new release under a new tag which will publish two new modules with matching tags.

The result is that github.com/awslabs/aws-lambda-go-api-proxy/echov4 will depend on echov4 and github.com/awslabs/aws-lambda-go-api-proxy but not the other way around.

Have a read of the process here.

https://github.com/golang/go/wiki/Modules#is-it-possible-to-add-a-module-to-a-multi-module-repository

I plan to try this on another copy of this repo for my own benefit but I believe it would reduce the hellish web of dependencies.

@sapessi
Copy link
Collaborator

sapessi commented Mar 24, 2020

Making this entire repo multi-module has been on my list for a while. I haven't had a chance to get to it.

@excavador
Copy link

Can we please merge this PR?

1 similar comment
@lucasmdomingues
Copy link

Can we please merge this PR?

@nnajiabraham
Copy link

nnajiabraham commented Mar 12, 2021

Just checking on this, any update or action item required for this to be merged, or could we just go ahead with adding the echov4 if making this a multi-module repo is a more complex task?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants