-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix upgrade echo to v4 as per upstream instructions #50
base: master
Are you sure you want to change the base?
Conversation
Were there any breaking changes between v4 and v3? Today we support v3 and I'm concerned that just changing to v4 may cause issues for existing users. |
@sapessi you make a very good point, with libraries like this it may require a new package or function to indicate different major versions. My experience due to the namespace changes you need to be explicit about echo vs v4. Did you want me to refactor this PR to be echov4 in a separate file / package? |
I would probably create it as a separate |
I think this repo is a good case for moving to a multi module project. This would look as follows:
The result is that github.com/awslabs/aws-lambda-go-api-proxy/echov4 will depend on echov4 and github.com/awslabs/aws-lambda-go-api-proxy but not the other way around. Have a read of the process here. I plan to try this on another copy of this repo for my own benefit but I believe it would reduce the hellish web of dependencies. |
Making this entire repo multi-module has been on my list for a while. I haven't had a chance to get to it. |
Can we please merge this PR? |
1 similar comment
Can we please merge this PR? |
Just checking on this, any update or action item required for this to be merged, or could we just go ahead with adding the echov4 if making this a multi-module repo is a more complex task? |
https://github.com/labstack/echo#supported-go-versions
Issue #, if available:
Description of changes:
Upgrade echo to v4 as per upstream instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.