support col match and change to DatasetMatch #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rdsharma26 could you please review this, thanks. |
rdsharma26
reviewed
Jan 23, 2024
src/main/scala/com/amazon/deequ/analyzers/DatasetMatchAnalyzer.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/amazon/deequ/analyzers/DatasetMatchState.scala
Outdated
Show resolved
Hide resolved
rdsharma26
reviewed
Feb 5, 2024
src/main/scala/com/amazon/deequ/analyzers/DatasetMatchAnalyzer.scala
Outdated
Show resolved
Hide resolved
rdsharma26
reviewed
Feb 5, 2024
src/main/scala/com/amazon/deequ/analyzers/DatasetMatchAnalyzer.scala
Outdated
Show resolved
Hide resolved
rdsharma26
approved these changes
Feb 5, 2024
thanks for review @rdsharma26 ... updated doc strings, could you please re-approve and merge PR. thanks |
eycho-am
pushed a commit
that referenced
this pull request
Feb 21, 2024
* update col match and other improvements * review comments * review comments
eycho-am
pushed a commit
that referenced
this pull request
Feb 21, 2024
* update col match and other improvements * review comments * review comments
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
* update col match and other improvements * review comments * review comments
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
* update col match and other improvements * review comments * review comments
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
* update col match and other improvements * review comments * review comments
rdsharma26
pushed a commit
that referenced
this pull request
Apr 17, 2024
* update col match and other improvements * review comments * review comments
rdsharma26
pushed a commit
that referenced
this pull request
Apr 17, 2024
* update col match and other improvements * review comments * review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue, if available: #501
Description of changes:
address review comments from here for DatasetMatch.
matchColumnMappingsfor datasetMatchDataSynchronizationtoDatasetMatchcc: @rdsharma26
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.