-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add analyzerOption to add filteredRowOutcome for isPrimaryKey Check #537
Merged
eycho-am
merged 2 commits into
awslabs:master
from
eycho-am:feature/rowLevelFilterPrimaryKey
Feb 23, 2024
Merged
Add analyzerOption to add filteredRowOutcome for isPrimaryKey Check #537
eycho-am
merged 2 commits into
awslabs:master
from
eycho-am:feature/rowLevelFilterPrimaryKey
Feb 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdsharma26
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Great job in keeping the Scala API backwards compatible.
eycho-am
force-pushed
the
feature/rowLevelFilterPrimaryKey
branch
from
February 22, 2024 22:39
261bdce
to
535684a
Compare
eycho-am
added a commit
that referenced
this pull request
Feb 23, 2024
…537) * Add analyzerOption to add filteredRowOutcome for isPrimaryKey Check * Add analyzerOption to add filteredRowOutcome for hasUniqueValueRatio Check
eycho-am
added a commit
that referenced
this pull request
Feb 23, 2024
…537) * Add analyzerOption to add filteredRowOutcome for isPrimaryKey Check * Add analyzerOption to add filteredRowOutcome for hasUniqueValueRatio Check
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
…537) * Add analyzerOption to add filteredRowOutcome for isPrimaryKey Check * Add analyzerOption to add filteredRowOutcome for hasUniqueValueRatio Check
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
…537) * Add analyzerOption to add filteredRowOutcome for isPrimaryKey Check * Add analyzerOption to add filteredRowOutcome for hasUniqueValueRatio Check
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
…537) * Add analyzerOption to add filteredRowOutcome for isPrimaryKey Check * Add analyzerOption to add filteredRowOutcome for hasUniqueValueRatio Check
rdsharma26
pushed a commit
that referenced
this pull request
Apr 17, 2024
…537) * Add analyzerOption to add filteredRowOutcome for isPrimaryKey Check * Add analyzerOption to add filteredRowOutcome for hasUniqueValueRatio Check
rdsharma26
pushed a commit
that referenced
this pull request
Apr 17, 2024
…537) * Add analyzerOption to add filteredRowOutcome for isPrimaryKey Check * Add analyzerOption to add filteredRowOutcome for hasUniqueValueRatio Check
arsenalgunnershubert777
pushed a commit
to arsenalgunnershubert777/deequ
that referenced
this pull request
Nov 8, 2024
…wslabs#537) * Add analyzerOption to add filteredRowOutcome for isPrimaryKey Check * Add analyzerOption to add filteredRowOutcome for hasUniqueValueRatio Check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Follow-up PR to #532 and #535
isPrimaryKey
Check which uses theUniqueness
analyzerBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.