Anomaly Detection: Add Daily Season with Hourly Interval to HoltWinter #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rdsharma26 Hi Can you help review this PR? It would be great if HoltWinter support more seasonality and interval. Also having a custom seriesPeriodicity would allow others to construct their own seasonality without always having to make changes to source code |
|
@zeotuan Thanks for the PR! The change looks good. However, would it be possible to add a unit test that shows how a custom value for |
|
@rdsharma26 Thanks. Tests Added for Custom seriesPeriodicity and Hourly Interval/Daily Seasonality |
rdsharma26
reviewed
Mar 10, 2024
src/test/scala/com/amazon/deequ/anomalydetection/seasonal/HoltWintersTest.scala
Outdated
Show resolved
Hide resolved
| @@ -207,6 +207,73 @@ class HoltWintersTest extends AnyWordSpec with Matchers { | |||
| anomalies should have size 3 | |||
| } | |||
| } | |||
|
|
|||
| "work on hourly data with daily seasonality" in { | |||
There was a problem hiding this comment.
Can you add a test for custom seriesPeriodicity as well? The two tests are testing the original constructor and not the new constructor.
|
I have addressed the comments. |
|
Thanks for addressing the comments. LGTM. |
rdsharma26
approved these changes
Mar 10, 2024
rdsharma26
pushed a commit
that referenced
this pull request
Apr 3, 2024
#546) * Add Daily Season with Hourly Interval, Add custom periodicity constructor * Add Custom seriesPeriodicity, Hourly interval with Daily seasonality tests * Add Test using custom seriesPeriodicity
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
#546) * Add Daily Season with Hourly Interval, Add custom periodicity constructor * Add Custom seriesPeriodicity, Hourly interval with Daily seasonality tests * Add Test using custom seriesPeriodicity
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
#546) * Add Daily Season with Hourly Interval, Add custom periodicity constructor * Add Custom seriesPeriodicity, Hourly interval with Daily seasonality tests * Add Test using custom seriesPeriodicity
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
#546) * Add Daily Season with Hourly Interval, Add custom periodicity constructor * Add Custom seriesPeriodicity, Hourly interval with Daily seasonality tests * Add Test using custom seriesPeriodicity
rdsharma26
pushed a commit
that referenced
this pull request
Apr 17, 2024
#546) * Add Daily Season with Hourly Interval, Add custom periodicity constructor * Add Custom seriesPeriodicity, Hourly interval with Daily seasonality tests * Add Test using custom seriesPeriodicity
rdsharma26
pushed a commit
that referenced
this pull request
Apr 17, 2024
#546) * Add Daily Season with Hourly Interval, Add custom periodicity constructor * Add Custom seriesPeriodicity, Hourly interval with Daily seasonality tests * Add Test using custom seriesPeriodicity
shriyavanvari
pushed a commit
that referenced
this pull request
May 2, 2024
#546) * Add Daily Season with Hourly Interval, Add custom periodicity constructor * Add Custom seriesPeriodicity, Hourly interval with Daily seasonality tests * Add Test using custom seriesPeriodicity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Daily Season with Hourly Interval to HoltWinter: #296
Add constructor that directly take seriesPeriodicity
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.