Fix row level bug when composing outcome #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When a check fails due to a precondition failure, the row level results are not evaluated correctly. - For example, let's say a check has a completeness constraint which passes, and a minimum constraint which fails due to a precondition failure. - The row level results will be the results for just the completeness constraint. There will be no results generated for the minimum constraint, and therefore the row level results will be incorrect. - We fix this by adding a default outcome for when the row level result column is not provided by the analyzer.
rdsharma26
force-pushed
the
column-type-failure-row-level-bug
branch
from
0e8c6b1 to
ddc0942
Compare
eycho-am
reviewed
Dec 16, 2024
| @@ -144,7 +145,7 @@ object VerificationResult { | |||
| val constraint = constraintResult.constraint | |||
| constraint match { | |||
| case asserted: RowLevelAssertedConstraint => | |||
| constraintResult.metric.flatMap(metricToColumn).map(asserted.assertion(_)) | |||
| constraintResult.metric.flatMap(metricToColumn).map(asserted.assertion(_)).orElse(Some(lit(false))) | |||
There was a problem hiding this comment.
I probably need to look at the code again, but could you remind me the difference between RowLevelAssertedConstraint and RowLevelConstraint / why we don't need to add it for the latter? Are RowLevelConstraint for checks like Completeness, Uniqueness where row level results are boolean and RowLevelAssertedConstraint are for checks like Minimum, Sum where we need to compare the row-level value to a given assertion?
|
One clarifying question, but otherwise lgtm |
eycho-am
approved these changes
Dec 16, 2024
SamPom100
approved these changes
Dec 16, 2024
Skipped RowLevelGroupedConstraint because only UniqueValueRatio/Uniqueness use it, and they don't use preconditions.
|
Addressed feedback in followup commit. |
eycho-am
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.