CLI cleanup #32
Open
CLI cleanup #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids needing to do type-conversions which look like errors
* Use easier to read variable names following PEP-8 * Default to a dry-run unless deletion is confirmed * Use a mutually-exclusive argument group to require command-line runs to specify either --dry-run or --delete-images. * Have --region default to $AWS_DEFAULT_REGION if set
* Easier to understand variable names * Print output has consistent use of colons * Fix typo * Use enumerate rather than reinventing it * Nicer display of the digests which would be deleted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing this locally and made several changes to make the process a bit nicer. Beyond some PEP-8 cleanup, here are the major changes: