-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated aws-sdk-kms dependencies & use default tls for reqwest #822
Merged
sumukhballal
merged 2 commits into
awslabs:develop
from
sumukhballal:update-aws-dependencies
Sep 10, 2024
Merged
Updated aws-sdk-kms dependencies & use default tls for reqwest #822
sumukhballal
merged 2 commits into
awslabs:develop
from
sumukhballal:update-aws-dependencies
Sep 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumukhballal
force-pushed
the
update-aws-dependencies
branch
2 times, most recently
from
September 9, 2024 20:59
580b66a
to
33a88ae
Compare
Added some comments for |
sumukhballal
force-pushed
the
update-aws-dependencies
branch
from
September 9, 2024 21:00
33a88ae
to
430feb9
Compare
Added the |
sumukhballal
force-pushed
the
update-aws-dependencies
branch
from
September 10, 2024 01:23
430feb9
to
3e7ca22
Compare
Added a change suggested by @jpculp ! |
sumukhballal
force-pushed
the
update-aws-dependencies
branch
from
September 10, 2024 01:28
3e7ca22
to
2e988e2
Compare
jpculp
approved these changes
Sep 10, 2024
bcressey
reviewed
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you split this into two commits? One for the dependency update and one for the reqwest
feature flag change?
bcressey
reviewed
Sep 10, 2024
sumukhballal
force-pushed
the
update-aws-dependencies
branch
from
September 10, 2024 20:36
2e988e2
to
a329db4
Compare
Addressed @bcressey 's comments. |
bcressey
approved these changes
Sep 10, 2024
mgsharm
approved these changes
Sep 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
reqwest
to use default-tls for on-host ca's instead of the one packaged withrust-tls
.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.