Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated aws-sdk-kms dependencies & use default tls for reqwest #822

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

sumukhballal
Copy link
Contributor

Description of changes:

  • Updated aws-sdk-kms to v1.41. It is required so we get the latest regions supported from the SDK.
  • Updated reqwest to use default-tls for on-host ca's instead of the one packaged with rust-tls.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sumukhballal sumukhballal force-pushed the update-aws-dependencies branch 2 times, most recently from 580b66a to 33a88ae Compare September 9, 2024 20:59
@sumukhballal
Copy link
Contributor Author

Added some comments for deny.toml.

@sumukhballal
Copy link
Contributor Author

Added the Cargo.lock file.

@sumukhballal
Copy link
Contributor Author

Added a change suggested by @jpculp !

Copy link
Contributor

@bcressey bcressey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you split this into two commits? One for the dependency update and one for the reqwest feature flag change?

tuftool/Cargo.toml Outdated Show resolved Hide resolved
@sumukhballal
Copy link
Contributor Author

Addressed @bcressey 's comments.

@sumukhballal sumukhballal merged commit 935a17b into awslabs:develop Sep 10, 2024
7 checks passed
@mgsharm mgsharm mentioned this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants