io_uring: Fix error status of cqe #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since cqe->res is expected to be a negative value of errno, it's been flipped to a positive value before passing it to io_u.c. However, in case of io_uring_cmd with cmd_type=nvme, cqe->res might represent a NVMe completion status type and code along with control fields such as DNR since nvme_uring_cmd_end_io() in the NVMe driver sets the completion status value and passes it up to io_uring. For example, If a DULBE(Deallocated or Unwritten Logical Block Error) is coming up from the device, cqe->res here would be 0x4287 which is a DULBE error code of media error type. This patch unified the error code to a positive value regardless of the error type. Signed-off-by: Minwoo Im <[email protected]>
The 'ignore_error=str' option expects either the name or the numeric value of the errno in string format. With recent additions like io_uring_cmd ioengine, it's been possible to check not only errno values but also the actual status values provided by the storage device. Given that most status codes in NVMe specs are represented in hexadecimal, specifying error values in hexadecimal is also useful to ignore some errors. For example, DULBE (Deallocated or Unwritten Logical Block Error) status code can be ignored: ignore_error=0x287 Signed-off-by: Minwoo Im <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'io_uring_cmd' ioengine returns the status code type and status code of
NVMe CQE [27:17] to io_u in case of errors. The first patch fixes the CQE
value being returned as negative since it's not an errno. The next one is a
trivial patch to support hexadecimal format to 'ignore_error' option to mask
values such as the status type and status code in a more comfortable way.