Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(axelar-gateway): move gateway types out of axelar-soroban-interfaces #42

Merged
merged 16 commits into from
Oct 28, 2024

Conversation

hydrobeam
Copy link
Contributor

@hydrobeam hydrobeam commented Oct 23, 2024

closes AXE-6155

Summary

  • renamed GatewayError to ContractError
  • moved contents of interfaces/types.rs to gateway/types.rs
    • maybe merge with storage_types.rs? held off since storage_types is a private module, meanwhile types needs to be pub since it's used in the integration tests.
    • moved the error type here too
  • dropped AxelarGatewayInterface in f88a5d9. required setting themethods in the AxelarGateway to pub
    • brought over the comments attached to the methods
  • moved over the tests in the interfaces crate as unit tests defined in types.rs.
    • because the tests depend on goldie which relies on std, I had to add a crate level cfg[test] + extern crate std;. otherwise I couldn't seem to get goldie to compile. adding extern crate std in the test module itself did not work
  • brought over the AxelarExecutableInterface to exectuable.rs
    • it depends on the AxelarGatewayClient so it made sense to handle in the same pr.
  • fix many imports

Laith added 3 commits October 23, 2024 14:13
@hydrobeam hydrobeam requested a review from a team as a code owner October 23, 2024 18:54
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 96.96970% with 5 lines in your changes missing coverage. Please review.

Project coverage is 98.97%. Comparing base (3e7d28a) to head (b7fba1b).

Files with missing lines Patch % Lines
contracts/axelar-gateway/src/contract.rs 90.90% 2 Missing ⚠️
contracts/axelar-gateway/src/auth.rs 94.73% 1 Missing ⚠️
contracts/axelar-gateway/src/error.rs 50.00% 1 Missing ⚠️
contracts/axelar-gateway/src/types.rs 99.18% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   98.97%   98.97%   -0.01%     
==========================================
  Files          23       23              
  Lines        2542     2630      +88     
==========================================
+ Hits         2516     2603      +87     
- Misses         26       27       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

contracts/axelar-gateway/src/contract.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/src/contract.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/src/types.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/src/test_auth.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/src/test_gateway.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/src/types.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/src/types.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/src/types.rs Outdated Show resolved Hide resolved
integration-tests/tests/gmp.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/src/types.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/src/types.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/src/lib.rs Show resolved Hide resolved
contracts/axelar-gateway/src/lib.rs Show resolved Hide resolved
contracts/axelar-gateway/src/executable.rs Show resolved Hide resolved
contracts/axelar-gateway/src/contract.rs Show resolved Hide resolved
contracts/axelar-gateway/src/contract.rs Outdated Show resolved Hide resolved
@milapsheth milapsheth changed the title refactor(gateway): move gateway types out of axelar-soroban-interfaces refactor(axelar-gateway): move gateway types out of axelar-soroban-interfaces Oct 24, 2024
contracts/axelar-gateway/src/contract.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/src/contract.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/src/lib.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants