-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(axelar-gateway): move gateway types out of axelar-soroban-interfaces
#42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also move tests for types.rs
use pub functions instead
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
==========================================
- Coverage 98.97% 98.97% -0.01%
==========================================
Files 23 23
Lines 2542 2630 +88
==========================================
+ Hits 2516 2603 +87
- Misses 26 27 +1 ☔ View full report in Codecov by Sentry. |
ahramy
reviewed
Oct 23, 2024
milapsheth
reviewed
Oct 24, 2024
milapsheth
changed the title
refactor(gateway): move gateway types out of
refactor(axelar-gateway): move gateway types out of Oct 24, 2024
axelar-soroban-interfaces
axelar-soroban-interfaces
bring in some details from reference evm contract docs
milapsheth
approved these changes
Oct 24, 2024
milapsheth
approved these changes
Oct 25, 2024
This was referenced Oct 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes AXE-6155
Summary
GatewayError
toContractError
interfaces/types.rs
togateway/types.rs
storage_types.rs
? held off sincestorage_types
is a private module, meanwhiletypes
needs to bepub
since it's used in the integration tests.AxelarGatewayInterface
in f88a5d9. required setting themethods in theAxelarGateway
topub
types.rs
.goldie
which relies on std, I had to add a crate levelcfg[test] + extern crate std;
. otherwise I couldn't seem to getgoldie
to compile. addingextern crate std
in the test module itself did not workAxelarExecutableInterface
toexectuable.rs