upgrade migrate signature

axelarnetwork · Dec 16, 2024 · e23e6cf · e23e6cf
1 parent c690b4b
commit e23e6cf
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/move/axelar_gateway/sources/gateway.move b/move/axelar_gateway/sources/gateway.move
@@ -177,8 +177,8 @@ entry fun rotate_signers(
 /// This function should only be called once
 /// (checks should be made on versioned to ensure this)
 /// It upgrades the version control to the new version control.
-entry fun migrate(self: &mut Gateway) {
-    self.inner.load_value_mut<Gateway_v0>().migrate(version_control());
+entry fun migrate(self: &mut Gateway, _: &OwnerCap, data: vector<u8>) {
+    self.inner.load_value_mut<Gateway_v0>().migrate(version_control(), data);
 }
 
 entry fun allow_function(

diff --git a/move/axelar_gateway/sources/versioned/gateway_v0.move b/move/axelar_gateway/sources/versioned/gateway_v0.move
@@ -38,6 +38,10 @@ const ENewerMessage: vector<u8> =
 const ECannotMigrateTwice: vector<u8> =
     b"attempting to migrate a even though migration is complete";
 
+#[error]
+const ENoDataAllowedOnMigrate: vector<u8> = 
+    b"no data should be passed to migrate to this version";
+
 // -----
 // Types
 // -----
@@ -79,8 +83,9 @@ public(package) fun version_control(self: &Gateway_v0): &VersionControl {
     &self.version_control
 }
 
-public(package) fun migrate(self: &mut Gateway_v0, mut version_control: VersionControl) {
+public(package) fun migrate(self: &mut Gateway_v0, mut version_control: VersionControl, data: vector<u8>) {
     assert!(self.version_control.allowed_functions().length() == version_control.allowed_functions().length() - 1, ECannotMigrateTwice );
+    assert!(data.length() == 0, ENoDataAllowedOnMigrate);
     self.version_control = version_control;
 }