feat: add MSS token #136
Merged
feat: add MSS token #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi I am resubmitting this as we migrated our BSC token contract to a new contract. I have setup a new bridge with our existing Base chain token and new BSC token, all is working great.
On my last submission there was questions about why using "mintBurnFrom". For that, its because I am able to give minting permissions to the token manager contract, but it doesn't have full burn permissions. With mintBurnFrom I get almost the same experience as mintBurn, just that the users have to approve the tokens for them to be burnt. Its working well for us