Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add KIP token #154

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Feat/add KIP token #154

merged 4 commits into from
Dec 11, 2024

Conversation

bizliaoyuan
Copy link
Contributor

@bizliaoyuan bizliaoyuan commented Dec 3, 2024

Adding KIP token to Squid token list.

https://kip.pro/

@bizliaoyuan bizliaoyuan changed the title add KIP token Feat/add KIP token Dec 3, 2024
@bizliaoyuan
Copy link
Contributor Author

bizliaoyuan commented Dec 3, 2024

@benjamin852 @Olanetsoft Please help review this change. Thank you!

Copy link
Collaborator

@ecdsafu ecdsafu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey guys, thanks for submitting. If you have a coingecko ID for this token could you please add it to the PR?

@bizliaoyuan
Copy link
Contributor Author

Thank you for your review. We currently do not have a CoinGecko ID. If we obtain one, we will promptly submit a new PR to update it. Thank you! @ecdsafu

Copy link
Collaborator

@ecdsafu ecdsafu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

# Conflicts:
#	registry/mainnet/interchain/squid.tokenlist.json
@bizliaoyuan
Copy link
Contributor Author

I've resolved the code conflicts. Could you help me merge it? @ecdsafu

@Olanetsoft Olanetsoft merged commit 671e1e3 into axelarnetwork:main Dec 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants