Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: axelar local dev multiversx #104

Merged
merged 15 commits into from
Mar 5, 2024
Merged

feat: axelar local dev multiversx #104

merged 15 commits into from
Mar 5, 2024

Conversation

raress96
Copy link
Contributor

No description provided.

@raress96 raress96 mentioned this pull request Feb 12, 2024
Merged
@npty npty self-requested a review February 14, 2024 02:04
npty
npty reviewed Feb 14, 2024
View reviewed changes
Copy link
Member

@npty npty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the PR 🙌🏻
it's lgtm. could you pls also add tests covering the relay between evm and multiversx? You can looks at aptos.spec.ts or near.spec.ts as a reference.

README.md Outdated Show resolved Hide resolved
@raress96
Copy link
Contributor Author

raress96 commented Feb 14, 2024 •
edited
Loading

Thanks for submitting the PR 🙌🏻 it's lgtm. could you pls also add tests covering the relay between evm and multiversx? You can looks at aptos.spec.ts or near.spec.ts as a reference.

Hello, I have added tests for MultiversX. Also updated the Github Action but not 100% sure if it will run correctly, if you can trigger it that would be great and I can update it accordingly.

@npty
Copy link
Member

npty commented Mar 1, 2024 •
edited
Loading

Thanks for submitting the PR 🙌🏻 it's lgtm. could you pls also add tests covering the relay between evm and multiversx? You can looks at aptos.spec.ts or near.spec.ts as a reference.

Hello, I have added tests for MultiversX. Also updated the Github Action but not 100% sure if it will run correctly, if you can trigger it that would be great and I can update it accordingly.

@raress96
Sorry, I've missed this. I've tried Github Action, it failed at the setup-python step. Could you try updating the working directory?

@raress96 raress96 force-pushed the multiversx_package branch 6 times, most recently from e19661b to 0d0c88d Compare March 1, 2024 11:08
@raress96 raress96 force-pushed the multiversx_package branch from 0d0c88d to 17998b5 Compare March 1, 2024 11:18
@raress96
Copy link
Contributor Author

raress96 commented Mar 1, 2024

Thanks for submitting the PR 🙌🏻 it's lgtm. could you pls also add tests covering the relay between evm and multiversx? You can looks at aptos.spec.ts or near.spec.ts as a reference.

Hello, I have added tests for MultiversX. Also updated the Github Action but not 100% sure if it will run correctly, if you can trigger it that would be great and I can update it accordingly.

@raress96 Sorry, I've missed this. I've tried Github Action, it failed at the setup-python step. Could you try updating the working directory?

The pipeline should be fixed.

@npty npty merged commit 679b066 into axelarnetwork:main Mar 5, 2024
1 check passed
@raress96 raress96 deleted the multiversx_package branch March 6, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npty npty npty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raress96 @npty